fix vitest on different node #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the Vitest configuration from TypeScript to JavaScript (.mjs) and drops Node.js 16.x support from CI workflows.
- Replaced
vitest.config.tswithvitest.config.mjsand removed the copyright header - Removed Node.js 16.x from the CI test matrix in both Linux and Windows workflows
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| vitest.config.ts | Deleted TypeScript configuration file |
| vitest.config.mjs | Added new JavaScript (ESM) configuration file without copyright header |
| .github/workflows/windows.yml | Removed Node.js 16.x from test matrix |
| .github/workflows/linux.yml | Removed Node.js 16.x from test matrix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+10
| import { defineConfig } from 'vitest/config'; | ||
|
|
||
| export default defineConfig({ | ||
| test: { | ||
| include: ['test/unit/**/*.test.ts'], | ||
| coverage: { | ||
| include: ['src/**'], | ||
| }, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
The copyright header present in the original vitest.config.ts has been removed. For consistency with the project's licensing requirements (Apache License 2.0), consider adding the copyright header to this new file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
增加对node 21的兼容，移除对node 16的兼容，以通过github action中的vitest